Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade UI #481

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Upgrade UI #481

merged 1 commit into from
Sep 27, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Sep 25, 2024

Description

  • Node from v18.9.1 to latest LTS version v20.17.0
  • pnpm from 8.6.12 to latest version 9.11.0
  • Including all transitive dependencies

Additional context and related issues

Release notes

(x) No release notes entry needed.

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2024
@mosabua mosabua marked this pull request as draft September 25, 2024 18:58
@mosabua mosabua changed the title Web Upgrade UI Sep 25, 2024
- Node from v18.9.1 to latest LTS version v20.17.0
- pnpm from 8.6.12 to latest version 9.11.0
- Including all transitive dependencies
@mosabua
Copy link
Member Author

mosabua commented Sep 26, 2024

Did you do any further testing on this @ytwp .. cause I did not..

@ebyhr
Copy link
Member

ebyhr commented Sep 27, 2024

(x) Release notes are required, with the following suggested text:

Why do we need to mention this change in release notes?

@ytwp
Copy link
Member

ytwp commented Sep 27, 2024

Did you do any further testing on this @ytwp .. cause I did not..

I have tested it, and Node v20.17.0 works well.
pnpm 9.11.0 also works well.

@mosabua mosabua marked this pull request as ready for review September 27, 2024 16:17
@mosabua
Copy link
Member Author

mosabua commented Sep 27, 2024

(x) Release notes are required, with the following suggested text:

Why do we need to mention this change in release notes?

I was thinking it might introduce some incompatibility with extensions or so but I think we are all good.

@mosabua mosabua merged commit 5b278c2 into trinodb:main Sep 27, 2024
3 checks passed
@mosabua mosabua deleted the web branch September 27, 2024 16:18
@github-actions github-actions bot added this to the 12 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants